Default to nil for contentInset #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthetechie
approved these changes
Dec 11, 2024
ianthetechie
added
the
release:patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Motivation
When we set mapViewContentInset, this sets automaticallyAdjustsContentInset to false on line 113. The current default value for automaticallyAdjustsContentInset is .zero at the moment instead of nil, so automaticallyAdjustsContentInset is always false, even if a developer is not using our mapViewContentInset.
This PR changes the default to nil, so that automaticallyAdjustsContentInset isn't affected if a developer is not using mapViewContentInset.